Skip to content

bpo-46329: Fix refleak in specialized isinstance error path #31005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2022
Merged

bpo-46329: Fix refleak in specialized isinstance error path #31005

merged 1 commit into from
Jan 29, 2022

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jan 29, 2022 •
edited by bedevere-bot
Loading

Since cls is POP-ed, error doesn't decref it since it decrefs from TOS down.

https://bugs.python.org/issue46329

@Fidget-Spinner
Copy link
Member Author

@pablogsal This fixes a refleak in GH-30855. Hopefully that means the refleak buildbots will now be green.

Before:

python -m test test_types -R 3:3 -m '*UnionTests.test_or_type_operator_with_genericalias'
0:00:00 Run tests sequentially
0:00:00 [1/1] test_types
beginning 6 repetitions
123456
......
test_types leaked [47, 47, 47] references, sum=141
test_types leaked [22, 22, 22] memory blocks, sum=66
test_types failed (reference leak)

After:

0:00:00 [1/1] test_types
beginning 6 repetitions
123456
......
== Tests result: SUCCESS ==

@markshannon
Copy link
Member

LGTM.
@pablogsal @ambv could you merge this, please?

@pablogsal pablogsal merged commit 8fb3649 into python:main Jan 29, 2022
@Fidget-Spinner Fidget-Spinner deleted the fix_isinstance_refleak branch January 29, 2022 14:38
pablogsal added a commit that referenced this pull request Jan 29, 2022
@pablogsal
Revert "fFx refleak in isinstance error path (GH-31005)"
d8e8cbc 
This reverts commit 8fb3649.
@brandtbucher brandtbucher mentioned this pull request Jan 29, 2022
Closed
ambv pushed a commit that referenced this pull request Jan 31, 2022
@pablogsal @ambv
Revert "fFx refleak in isinstance error path (GH-31005)"
ada2b00 
This reverts commit 8fb3649.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Fidget-Spinner @markshannon @brandtbucher @pablogsal @the-knights-who-say-ni @bedevere-bot